Fixes Error prone null checks in Pipelines batch submodule #1484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1484 +/- ##
============================================
- Coverage 46.66% 46.54% -0.13%
- Complexity 676 677 +1
============================================
Files 90 90
Lines 5874 5898 +24
Branches 814 826 +12
============================================
+ Hits 2741 2745 +4
- Misses 2828 2845 +17
- Partials 305 308 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8 tasks
bashir2
reviewed
Oct 15, 2025
Collaborator
bashir2
left a comment
bashir2
left a comment
There was a problem hiding this comment.
Thanks @ndegwamartin for the changes.
pipelines/batch/src/main/java/com/google/fhir/analytics/metrics/FlinkJobListener.java
Outdated
Show resolved
Hide resolved
pipelines/batch/src/main/java/com/google/fhir/analytics/ConvertResourceFn.java
Outdated
Show resolved
Hide resolved
pipelines/batch/src/main/java/com/google/fhir/analytics/FetchResources.java
Outdated
Show resolved
Hide resolved
pipelines/batch/src/main/java/com/google/fhir/analytics/FetchSearchPageFn.java
Show resolved
Hide resolved
pipelines/batch/src/main/java/com/google/fhir/analytics/JdbcResourceWriter.java
Outdated
Show resolved
Hide resolved
pipelines/batch/src/main/java/com/google/fhir/analytics/ParquetMerger.java
Outdated
Show resolved
Hide resolved
pipelines/batch/src/main/java/com/google/fhir/analytics/ProcessGenericRecords.java
Outdated
Show resolved
Hide resolved
pipelines/batch/src/main/java/com/google/fhir/analytics/ParquetMerger.java
Outdated
Show resolved
Hide resolved
bashir2
approved these changes
Nov 6, 2025
Collaborator
bashir2
left a comment
bashir2
left a comment
There was a problem hiding this comment.
Thanks for the changes @ndegwamartin; please feel free to merge this once the minor remaining comments are addressed.
pipelines/batch/src/main/java/com/google/fhir/analytics/FetchSearchPageFn.java
Show resolved
Hide resolved
pipelines/batch/src/main/java/com/google/fhir/analytics/ParquetMerger.java
Outdated
Show resolved
Hide resolved
Collaborator
|
/gcbrun |
Collaborator
Author
|
/gcbrun |
Collaborator
|
The e2e test succeeded on this a few minutes ago, here is the Cloud Build link (not sure why GitHub is not picking that up); merging ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Ticket #1474
E2E test
TESTED:
Please replace this with a description of how you tested your PR beyond the
automated e2e/unit tests.
Checklist: I completed these to help reviewers :)
I have read and will follow the
review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review
Java and
Python style guides.
My IDE is configured to follow the Google
code styles.
No? Unsure? ->
configure your IDE.
I have added tests to cover my changes. (If you refactored existing
code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
If I made any Python code changes, I ran
black .andpylint .rightbefore creating this pull request and added all formatting changes to my
commit.
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master